Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better translations in templates #78

Open
mak001 opened this issue Jul 19, 2022 · 1 comment
Open

Better translations in templates #78

mak001 opened this issue Jul 19, 2022 · 1 comment

Comments

@mak001
Copy link
Contributor

mak001 commented Jul 19, 2022

Put translations into templates instead of passing them as props into the template
This would save on complexity of data flowing into the templates. This would allow for more things to be translatable with custom templates without having two different ways of translating in one template.
Would also be more inline with the loading template.

@mak001
Copy link
Contributor Author

mak001 commented Jul 19, 2022

Removing the passed text could break projects. It may be worth it to keep the text but still re-do the templates in the module and examples so future implementations don't use the props.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant