Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add IBC channel creation capability from roller relayer start command #74

Merged
merged 1 commit into from
Jun 22, 2023
Merged

feat: Add IBC channel creation capability from roller relayer start command #74

merged 1 commit into from
Jun 22, 2023

Conversation

ItayLevyOfficial
Copy link
Contributor

@ItayLevyOfficial ItayLevyOfficial commented Jun 15, 2023 •
edited
Loading

PR Standards

Opening a pull request should be able to meet the following requirements

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@ItayLevyOfficial ItayLevyOfficial changed the base branch from main to itaylevyofficial/70-run-da-light-node June 15, 2023 16:13
@ItayLevyOfficial ItayLevyOfficial force-pushed the itaylevyofficial/70-run-da-light-node branch from cfd8958 to bb481b9 Compare June 18, 2023 08:21
@ItayLevyOfficial ItayLevyOfficial force-pushed the itaylevyofficial/57-roller-connect-create-channel branch from 1cd42df to 27449bb Compare June 18, 2023 08:41
@ItayLevyOfficial ItayLevyOfficial linked an issue Jun 18, 2023 that may be closed by this pull request
Allow creation of an hub-rollapp IBC channel with the roller relayer start command #57
Closed
@ItayLevyOfficial ItayLevyOfficial force-pushed the itaylevyofficial/70-run-da-light-node branch from bb481b9 to 6b73731 Compare June 20, 2023 09:51
Base automatically changed from itaylevyofficial/70-run-da-light-node to main June 21, 2023 10:58
@ItayLevyOfficial ItayLevyOfficial force-pushed the itaylevyofficial/57-roller-connect-create-channel branch from 55504a9 to 1545477 Compare June 21, 2023 12:53
@ItayLevyOfficial ItayLevyOfficial changed the title Itaylevyofficial/57 roller connect create channel feat: Add IBC channel creation capability from roller relayer start command Jun 21, 2023
@ItayLevyOfficial ItayLevyOfficial marked this pull request as ready for review June 21, 2023 12:54
@ItayLevyOfficial ItayLevyOfficial requested a review from a team as a code owner June 21, 2023 12:54
@ItayLevyOfficial ItayLevyOfficial merged commit 8619333 into main Jun 22, 2023
@ItayLevyOfficial ItayLevyOfficial deleted the itaylevyofficial/57-roller-connect-create-channel branch June 22, 2023 11:23
This was referenced Sep 18, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omritoptix omritoptix omritoptix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow creation of an hub-rollapp IBC channel with the roller relayer start command
2 participants
@ItayLevyOfficial @omritoptix