Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add ability to run Celestia DA light node #71

Merged
merged 4 commits into from
Jun 21, 2023
Merged

feat: Add ability to run Celestia DA light node #71

merged 4 commits into from
Jun 21, 2023

Conversation

ItayLevyOfficial
Copy link
Contributor

@ItayLevyOfficial ItayLevyOfficial commented Jun 13, 2023 •
edited
Loading

PR Standards

Opening a pull request should be able to meet the following requirements

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@ItayLevyOfficial ItayLevyOfficial changed the title Itaylevyofficial/70 run da light node feat: Add ability to run Celestia DA light node Jun 13, 2023
@ItayLevyOfficial ItayLevyOfficial linked an issue Jun 13, 2023 that may be closed by this pull request
Add running celestia light node capability on roller da-light-client run #70
Closed
@ItayLevyOfficial ItayLevyOfficial force-pushed the itaylevyofficial/58-run-error-handling branch from 513e5f1 to 823119c Compare June 15, 2023 17:32
@ItayLevyOfficial ItayLevyOfficial force-pushed the itaylevyofficial/70-run-da-light-node branch from cfd8958 to bb481b9 Compare June 18, 2023 08:21
@ItayLevyOfficial ItayLevyOfficial force-pushed the itaylevyofficial/58-run-error-handling branch from 823119c to a353b32 Compare June 19, 2023 15:57
@ItayLevyOfficial ItayLevyOfficial changed the base branch from itaylevyofficial/58-run-error-handling to main June 20, 2023 09:46
@ItayLevyOfficial ItayLevyOfficial force-pushed the itaylevyofficial/70-run-da-light-node branch from bb481b9 to 6b73731 Compare June 20, 2023 09:51
@ItayLevyOfficial ItayLevyOfficial marked this pull request as ready for review June 20, 2023 09:59
@ItayLevyOfficial ItayLevyOfficial requested a review from a team as a code owner June 20, 2023 09:59
omritoptix
omritoptix reviewed Jun 21, 2023
View reviewed changes
cmd/da-light-client/start/start.go Outdated Show resolved Hide resolved
cmd/utils/error_handling.go Outdated Show resolved Hide resolved
@ItayLevyOfficial ItayLevyOfficial merged commit eb18261 into main Jun 21, 2023
@ItayLevyOfficial ItayLevyOfficial deleted the itaylevyofficial/70-run-da-light-node branch June 21, 2023 10:58
This was referenced Sep 18, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omritoptix omritoptix omritoptix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add running celestia light node capability on roller da-light-client run
2 participants
@ItayLevyOfficial @omritoptix