feat!: Add support for standard ibc #614
Conversation
… periodic commands.
cmd/tx/register/bash_commands.go
Outdated
| @@ -14,7 +14,7 @@ import ( | |||
|
|
|||
| func getRegisterRollappCmd(rollappConfig config.RollappConfig) *exec.Cmd { | |||
| cmdArgs := []string{ | |||
| "tx", "rollapp", "create-rollapp", rollappConfig.RollappID, "stamp1", "genesis-path/1", "3", "3", `{"Addresses":[]}`, | |||
| "tx", "rollapp", "create-rollapp", rollappConfig.RollappID, "3", `{"Addresses":[]}`, | |||
There was a problem hiding this comment.
we need to supply the tokenMetada, so it will be used by the denommetada middleware
I had a branch for it IIRC
…ding coin-type 60 relayer keys.
| if err := utils.ExecBashCmd(createClientsCmd, logFileOption); err != nil { | ||
| return ConnectionChannels{}, err | ||
| } | ||
|
|
||
| //after successful update clients, keep running in the background | ||
| updateClientsCmd := r.GetUpdateClientsCmd() | ||
| utils.RunCommandEvery(ctx, updateClientsCmd.Path, updateClientsCmd.Args[1:], 20, utils.WithDiscardLogging()) |
There was a problem hiding this comment.
how it supposed to work when no clients created?
There was a problem hiding this comment.
it loops without success until clients are created. as the commands of clients creation are part of the link creation, and not their own separate command, it becomes more complicated to only run it after client creation. agree it's not ideal and we could query the chains until clients are created but I don't think it's worth the effort currently as the con is simply letting it fail for a few seconds until the clients are created.
There was a problem hiding this comment.
yeah but will it create the "txs" to release the empty blocks?
IIRC we did it for that
There was a problem hiding this comment.
yea it's fine. the txs for releasing empty blocks are required only after the create clients which are not dependent in that.
| return prevVersion.Major < 1 | ||
| } | ||
|
|
||
| func (v *VersionMigratorV1000) PerformMigration(rlpCfg config.RollappConfig) error { |
There was a problem hiding this comment.
No changes required on the rollapp itself? how it's state will change to use the tendermint IBC?
There was a problem hiding this comment.
the change to the rollapp itself is in the rollapp binary.
| fmt.Println("💈 Updating relayer configuration to match new relayer...") | ||
| if err := relayer.UpdateRlyConfigValue(rlpCfg, []string{"chains", rlpCfg.RollappID, "value", "extra-codecs"}, []string{"ethermint"}); err != nil { | ||
| fmt.Println("💈 Migrating Rollapp key...") | ||
| migrateRollappKeyCmd := exec.Command(consts.Executables.RollappEVM, "keys", "migrate", "--home", rlpCfg.Home+"/relayer/keys/"+rlpCfg.RollappID, "--keyring-backend", "test") |
There was a problem hiding this comment.
doesn't rly have this migrate functionally? by rly keys list maybe?
just to avoid the dependency on the rollapp/hub binary
There was a problem hiding this comment.
it doesn't have it.
| if err != nil { | ||
| fmt.Println(out.String()) | ||
| fmt.Println("💈 Updating relayer configuration to match new relayer key...") | ||
| if err := relayer.UpdateRlyConfigValue(rlpCfg, []string{"chains", rlpCfg.RollappID, "value", "extra-codecs"}, []string{"ethermint"}); err != nil { |
There was a problem hiding this comment.
the ethermint codec won't break something with non-evm rollapp?
PR Standards
Opening a pull request should be able to meet the following requirements
For Author:
godoccommentsFor Reviewer:
After reviewer approval: