Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Change to use coin type 60 instead of 118 for the hub keys #543

Merged
merged 2 commits into from
Oct 4, 2023
Merged

fix: Change to use coin type 60 instead of 118 for the hub keys #543

merged 2 commits into from
Oct 4, 2023

Conversation

ItayLevyOfficial
Copy link
Contributor

PR Standards

Opening a pull request should be able to meet the following requirements

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@ItayLevyOfficial ItayLevyOfficial linked an issue Oct 3, 2023 that may be closed by this pull request
Remove --algo flag when generating dymd keys #539
Closed
@ItayLevyOfficial ItayLevyOfficial marked this pull request as ready for review October 3, 2023 15:18
@ItayLevyOfficial ItayLevyOfficial requested a review from a team as a code owner October 3, 2023 15:18
@ItayLevyOfficial ItayLevyOfficial merged commit 337db9f into main Oct 4, 2023
4 of 6 checks passed
@ItayLevyOfficial ItayLevyOfficial deleted the itaylevyofficial/539-remove-algo-key branch October 4, 2023 07:32
mtsitrin pushed a commit that referenced this pull request Dec 10, 2023
@ItayLevyOfficial @mtsitrin
fix: Change to use coin type 60 instead of 118 for the hub keys (#543)
b31ab00
This was referenced Sep 18, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtsitrin mtsitrin mtsitrin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove --algo flag when generating dymd keys
2 participants
@ItayLevyOfficial @mtsitrin