Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add command to modify DA light client rpc port #369

Merged
merged 15 commits into from
Aug 14, 2023
Merged

feat: Add command to modify DA light client rpc port #369

merged 15 commits into from
Aug 14, 2023

Conversation

ItayLevyOfficial
Copy link
Contributor

@ItayLevyOfficial ItayLevyOfficial commented Aug 8, 2023 •
edited
Loading

PR Standards

Opening a pull request should be able to meet the following requirements

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@ItayLevyOfficial ItayLevyOfficial linked an issue Aug 8, 2023 that may be closed by this pull request
da light client gateway port should not be hardcoded #366
Closed
Base automatically changed from itaylevyofficial/255-configurable-rollapp-rpc to main August 9, 2023 12:59
@ItayLevyOfficial ItayLevyOfficial marked this pull request as ready for review August 13, 2023 08:56
@ItayLevyOfficial ItayLevyOfficial requested a review from a team as a code owner August 13, 2023 08:56
omritoptix
omritoptix reviewed Aug 14, 2023
View reviewed changes
data_layer/celestia/celestia.go Outdated Show resolved Hide resolved
data_layer/celestia/celestia.go Show resolved Hide resolved
@ItayLevyOfficial ItayLevyOfficial force-pushed the itaylevyofficial/366-configurable-lc-port branch from 7d4e9f2 to 82320ed Compare August 14, 2023 14:43
@ItayLevyOfficial ItayLevyOfficial merged commit c082e0d into main Aug 14, 2023
@ItayLevyOfficial ItayLevyOfficial deleted the itaylevyofficial/366-configurable-lc-port branch August 14, 2023 14:55
omritoptix added a commit that referenced this pull request Aug 15, 2023
@omritoptix
Revert "feat: Add command to modify DA light client rpc port (#369)"
353d449 
This reverts commit c082e0d.
This was referenced Sep 18, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omritoptix omritoptix omritoptix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

da light client gateway port should not be hardcoded
2 participants
@ItayLevyOfficial @omritoptix