feat: add support for avail as a da #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e5ccda2.
…service-output-should-be-generalised-for-da-layer
…rt-for-avail-as-a-da
…rt-for-avail-as-a-da
ItayLevyOfficial
approved these changes
Jul 17, 2023
| @@ -40,10 +41,13 @@ func Cmd() *cobra.Command { | |||
| out, err := utils.ExecBashCommand(exportKeyCmd) | |||
| printKeyOutput(out.String(), err) | |||
| } else if keyID != "" && keyID == damanager.GetKeyName() { | |||
| //TODO: avail doesn't need cmd to get the keys, it's stored in the config | |||
There was a problem hiding this comment.
avail doesn't get included in the supported keys in this flow right
There was a problem hiding this comment.
I know, there should be issue to handle it
| @@ -36,10 +38,11 @@ func NewDAManager(datype config.DAType, home string) *DAManager { | |||
| dalayer = &celestia.Celestia{ | |||
| Root: home, | |||
| } | |||
| case config.Avail: | |||
| dalayer = avail.NewAvail(home) | |||
There was a problem hiding this comment.
maybe break newavail to constructor and init config, like celestia?
There was a problem hiding this comment.
the init of celestia is for the light client. we don't have light client in avail
| @@ -13,7 +12,7 @@ type DAMock struct { | |||
| } | |||
|
|
|||
| func (d *DAMock) GetStatus(c config.RollappConfig) string { | |||
| return "" | |||
| return "Running mock DA" | |||
There was a problem hiding this comment.
the DA row is displayed now, u prefer something else to be written for mock DA?
This was referenced Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Standards
Opening a pull request should be able to meet the following requirements
For Author:
godoccommentsFor Reviewer:
After reviewer approval: