Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Reliable status for rollapp sequencer and relayer #204

Merged
merged 6 commits into from
Jul 6, 2023
Merged

fix: Reliable status for rollapp sequencer and relayer #204

merged 6 commits into from
Jul 6, 2023

Conversation

ItayLevyOfficial
Copy link
Contributor

@ItayLevyOfficial ItayLevyOfficial commented Jul 6, 2023 •
edited
Loading

PR Standards

Opening a pull request should be able to meet the following requirements

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@ItayLevyOfficial ItayLevyOfficial linked an issue Jul 6, 2023 that may be closed by this pull request
Run output should show correct status for relayer and sequencer #190
Closed
@ItayLevyOfficial ItayLevyOfficial marked this pull request as ready for review July 6, 2023 07:45
@ItayLevyOfficial ItayLevyOfficial requested a review from a team as a code owner July 6, 2023 07:45
mtsitrin
mtsitrin reviewed Jul 6, 2023
View reviewed changes
sequencer/status.go
if err := json.Unmarshal(body, &response); err != nil {
return false
}
return response.Result.NodeInfo.Network == rollappID
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what u checking here? why not just check for 200OK?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it can be another network. As discussed on #197, sometimes the sequencer does not terminates, which can cause the endpoint to return a healthy status when it is running another rollapp.

data_layer/damock/damock.go Outdated Show resolved Hide resolved
relayer/query_relayer_data.go Show resolved Hide resolved
data_layer/celestia/celestia.go Show resolved Hide resolved
utils/service_manager/service.go Show resolved Hide resolved
@ItayLevyOfficial ItayLevyOfficial requested a review from mtsitrin July 6, 2023 11:26
@mtsitrin mtsitrin merged commit 9ad3320 into main Jul 6, 2023
@mtsitrin mtsitrin deleted the itaylevyofficial/190-relayer-show-channels branch July 6, 2023 12:30
This was referenced Sep 18, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtsitrin mtsitrin mtsitrin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run output should show correct status for relayer and sequencer
2 participants
@ItayLevyOfficial @mtsitrin