Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add ability to list roller addresses with roller keys list command #83

Merged
merged 1 commit into from
Jun 25, 2023
Merged

feat: Add ability to list roller addresses with roller keys list command #83

merged 1 commit into from
Jun 25, 2023

Conversation

ItayLevyOfficial
Copy link
Contributor

@ItayLevyOfficial ItayLevyOfficial commented Jun 20, 2023 •
edited
Loading

PR Standards

Opening a pull request should be able to meet the following requirements

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@ItayLevyOfficial ItayLevyOfficial linked an issue Jun 20, 2023 that may be closed by this pull request
Implement a roller keys list command to list the roller addresses #63
Closed
@ItayLevyOfficial ItayLevyOfficial added enhancement New feature or request and removed enhancement New feature or request labels Jun 20, 2023
@ItayLevyOfficial ItayLevyOfficial force-pushed the itaylevyofficial/75-roller-connect-start-relayer branch from a47dc7e to 66597b4 Compare June 22, 2023 11:54
Base automatically changed from itaylevyofficial/75-roller-connect-start-relayer to main June 22, 2023 16:58
@ItayLevyOfficial ItayLevyOfficial force-pushed the itaylevyofficial/63-roller-list-keys branch from e9ce51a to 5e538ba Compare June 25, 2023 08:29
@ItayLevyOfficial ItayLevyOfficial marked this pull request as ready for review June 25, 2023 08:29
@ItayLevyOfficial ItayLevyOfficial requested a review from a team as a code owner June 25, 2023 08:29
@ItayLevyOfficial ItayLevyOfficial merged commit b4c875e into main Jun 25, 2023
@ItayLevyOfficial ItayLevyOfficial deleted the itaylevyofficial/63-roller-list-keys branch June 25, 2023 08:55
This was referenced Sep 18, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omritoptix omritoptix omritoptix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement a roller keys list command to list the roller addresses
2 participants
@ItayLevyOfficial @omritoptix