Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check whether rollapp exists during initialization #829

Merged

Conversation

artemijspavlovs
Copy link
Collaborator

chore: move GetRegisteredSequencers to sequencer package
fix: load rollapp id from roller config during run
chore: update rollapp_id during init

PR Standards

Opening a pull request should be able to meet the following requirements


For Author:

  • Targeted PR against correct branch
  • Included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case PR targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

chore: move GetRegisteredSequencers to sequencer package
fix: load rollapp id from roller config during run
chore: update rollapp_id during init
@artemijspavlovs artemijspavlovs requested a review from a team as a code owner August 12, 2024 11:28
@artemijspavlovs artemijspavlovs merged commit ded5e48 into main Aug 12, 2024
2 checks passed
@artemijspavlovs artemijspavlovs deleted the artemijspavlovs/check-rollapp-before-init-and-run branch August 12, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant