Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle genesis creator archive #800

Merged
merged 5 commits into from
Jul 8, 2024
Merged

feat: handle genesis creator archive #800

merged 5 commits into from
Jul 8, 2024

Conversation

artemijspavlovs
Copy link
Collaborator

@artemijspavlovs artemijspavlovs commented Jul 7, 2024 •
edited
Loading

PR Standards

Opening a pull request should be able to meet the following requirements

relayer code is commented out as it'll be a part of a relayer subcommand and is not relevant rn

close #801

For Author:

  • Targeted PR against correct branch
  • Included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case PR targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@artemijspavlovs
chore: add archive helpers for handling genesis-creator archive
86c1dc0
@artemijspavlovs
feat: add rollapp subcommand
6df0c82
@artemijspavlovs
fix: archive helpers
6a78595
@artemijspavlovs
chore: move archive helpers to a separate package
f403bd0 
feat: initialize the rollapp through 'rollapp' cmd
refactor: remove interactive cmd
refactor: retrieve config values from the generated roller.toml file
refactor: disable tests as the flow changes
refactor: make config init functions public
@artemijspavlovs
refactor: cleanup
353bd02 
chore: add refactor as a valid conventional commit msg
@artemijspavlovs artemijspavlovs requested a review from a team as a code owner July 7, 2024 14:38
@artemijspavlovs artemijspavlovs mentioned this pull request Jul 8, 2024
Open
@artemijspavlovs artemijspavlovs linked an issue Jul 8, 2024 that may be closed by this pull request
[Feature Request]: rollapp init command for running a RollApp locally #794
Open
@artemijspavlovs artemijspavlovs removed a link to an issue Jul 8, 2024
[Feature Request]: rollapp init command for running a RollApp locally #794
Open
@artemijspavlovs artemijspavlovs linked an issue Jul 8, 2024 that may be closed by this pull request
[Feature Request]: retrieve configuration and genesis from an archive #801
Closed
@artemijspavlovs artemijspavlovs merged commit e3ea97c into main Jul 8, 2024
2 checks passed
@artemijspavlovs artemijspavlovs deleted the artemijspavlovs/handle-genesis-creator-archive branch July 8, 2024 08:31
@github-actions github-actions bot mentioned this pull request Jun 21, 2024
Merged
This was referenced Sep 18, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: retrieve configuration and genesis from an archive
1 participant
@artemijspavlovs