Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added configuration files generation ability to roller init #8

Merged
merged 7 commits into from
May 30, 2023
Merged

feat: Added configuration files generation ability to roller init #8

merged 7 commits into from
May 30, 2023

Conversation

ItayLevyOfficial
Copy link
Contributor

@ItayLevyOfficial ItayLevyOfficial commented May 24, 2023 •
edited
Loading

PR Standards

Opening a pull request should be able to meet the following requirements

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@ItayLevyOfficial ItayLevyOfficial changed the title Implemented the config init stage keys generation feat: roller config init config generation => Added configuration files generation ability to roller init #6 May 24, 2023
@ItayLevyOfficial ItayLevyOfficial changed the title feat: roller config init config generation => Added configuration files generation ability to roller init #6 Added configuration files generation ability to roller init #6 May 24, 2023
@ItayLevyOfficial ItayLevyOfficial linked an issue May 24, 2023 that may be closed by this pull request
Roller config init - Implement configuration files generation #7
Closed
@ItayLevyOfficial ItayLevyOfficial added the enhancement New feature or request label May 24, 2023
@ItayLevyOfficial ItayLevyOfficial force-pushed the itaylevyofficial/7-init-coniguration-generation branch from a2152cd to abf1344 Compare May 29, 2023 08:17
@ItayLevyOfficial ItayLevyOfficial marked this pull request as ready for review May 29, 2023 08:19
@ItayLevyOfficial ItayLevyOfficial requested a review from a team as a code owner May 29, 2023 08:19
@ItayLevyOfficial ItayLevyOfficial changed the title Added configuration files generation ability to roller init #6 feat: Added configuration files generation ability to roller init #6 May 29, 2023
@ItayLevyOfficial ItayLevyOfficial self-assigned this May 29, 2023
mtsitrin
mtsitrin reviewed May 29, 2023
View reviewed changes
cmd/config/init/config.go Outdated Show resolved Hide resolved
cmd/config/init/config.go Outdated Show resolved Hide resolved
cmd/config/init/init.go Outdated Show resolved Hide resolved
omritoptix
omritoptix reviewed May 29, 2023
View reviewed changes
cmd/config/init/config.go Outdated Show resolved Hide resolved
cmd/config/init/init.go Outdated Show resolved Hide resolved
cmd/config/init/init.go Outdated Show resolved Hide resolved
cmd/config/init/init.go Outdated Show resolved Hide resolved
cmd/config/init/keys.go Outdated Show resolved Hide resolved
@omritoptix omritoptix changed the title feat: Added configuration files generation ability to roller init #6 feat: Added configuration files generation ability to roller init May 30, 2023
mtsitrin
mtsitrin approved these changes May 30, 2023
View reviewed changes
cmd/config/init/init.go Outdated

func getDenom(denom string, chainId string) string {
if denom == "" {
return "a" + chainId[:3]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to have some default value in the flag
not sure "a" + chainId[:3] make much sense as the denom default

@ItayLevyOfficial
Replaced denom flag with a param
dac083d
@ItayLevyOfficial
Merge branch 'itaylevyofficial/7-init-coniguration-generation' of git…
08cc9fe 
…hub.com:dymensionxyz/roller into itaylevyofficial/7-init-coniguration-generation
@ItayLevyOfficial ItayLevyOfficial merged commit de8f0a7 into main May 30, 2023
@ItayLevyOfficial ItayLevyOfficial deleted the itaylevyofficial/7-init-coniguration-generation branch May 30, 2023 10:34
This was referenced Sep 18, 2024
Closed
Closed
Closed
@github-actions github-actions bot mentioned this pull request Sep 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtsitrin mtsitrin mtsitrin approved these changes

@omritoptix omritoptix omritoptix approved these changes

Assignees

@ItayLevyOfficial ItayLevyOfficial

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Roller config init - Implement configuration files generation
3 participants
@ItayLevyOfficial @omritoptix @mtsitrin