Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add output formatting for roller register command #62

Merged
merged 1 commit into from
Jun 15, 2023
Merged

feat: Add output formatting for roller register command #62

merged 1 commit into from
Jun 15, 2023

Conversation

ItayLevyOfficial
Copy link
Contributor

@ItayLevyOfficial ItayLevyOfficial commented Jun 11, 2023 •
edited
Loading

PR Standards

Opening a pull request should be able to meet the following requirements

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@ItayLevyOfficial ItayLevyOfficial changed the title Implemented Output formatting for roller register feat: Implemented Output formatting for roller register Jun 11, 2023
@ItayLevyOfficial ItayLevyOfficial linked an issue Jun 11, 2023 that may be closed by this pull request
Output formatting for roller register #61
Closed
@ItayLevyOfficial ItayLevyOfficial marked this pull request as ready for review June 11, 2023 09:40
@ItayLevyOfficial ItayLevyOfficial requested a review from a team as a code owner June 11, 2023 09:40
@ItayLevyOfficial ItayLevyOfficial marked this pull request as draft June 11, 2023 09:41
@ItayLevyOfficial ItayLevyOfficial changed the title feat: Implemented Output formatting for roller register feat: Added output formatting for roller register command Jun 11, 2023
@ItayLevyOfficial ItayLevyOfficial changed the title feat: Added output formatting for roller register command feat: Added output formatting for roller register command Jun 11, 2023
@omritoptix omritoptix changed the title feat: Added output formatting for roller register command feat: Add output formatting for roller register command Jun 11, 2023
@ItayLevyOfficial ItayLevyOfficial force-pushed the itaylevyofficial/54-configurable-hub branch from e0d67b6 to ddc6404 Compare June 13, 2023 15:32
Base automatically changed from itaylevyofficial/54-configurable-hub to main June 14, 2023 10:34
@ItayLevyOfficial ItayLevyOfficial force-pushed the itaylevyofficial/61-register-output branch from 5bc5ae8 to 74eeec8 Compare June 14, 2023 11:37
@ItayLevyOfficial ItayLevyOfficial marked this pull request as ready for review June 14, 2023 11:39
@ItayLevyOfficial ItayLevyOfficial merged commit eaa2728 into main Jun 15, 2023
@ItayLevyOfficial ItayLevyOfficial deleted the itaylevyofficial/61-register-output branch June 15, 2023 08:27
This was referenced Sep 18, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omritoptix omritoptix omritoptix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Output formatting for roller register
2 participants
@ItayLevyOfficial @omritoptix