Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add ability to switch between different hub environments #55

Merged
merged 1 commit into from
Jun 14, 2023
Merged

feat: Add ability to switch between different hub environments #55

merged 1 commit into from
Jun 14, 2023

Conversation

ItayLevyOfficial
Copy link
Contributor

@ItayLevyOfficial ItayLevyOfficial commented Jun 8, 2023 •
edited
Loading

PR Standards

Opening a pull request should be able to meet the following requirements

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@ItayLevyOfficial ItayLevyOfficial linked an issue Jun 8, 2023 that may be closed by this pull request
Make the hub configurable between devnet and mainnet #54
Closed
@ItayLevyOfficial ItayLevyOfficial changed the title Implemented an optional hub flag feat: Implemented an optional hub flag Jun 8, 2023
@omritoptix omritoptix changed the title feat: Implemented an optional hub flag feat: Ability to switch between different hub environments Jun 11, 2023
@ItayLevyOfficial ItayLevyOfficial changed the title feat: Ability to switch between different hub environments feat: Added ability to switch between different hub environments Jun 11, 2023
@omritoptix omritoptix changed the title feat: Added ability to switch between different hub environments feat: Add ability to switch between different hub environments Jun 11, 2023
@ItayLevyOfficial ItayLevyOfficial force-pushed the itaylevyofficial/49-register-error-handling branch from 391985a to 22bd39c Compare June 12, 2023 10:37
Base automatically changed from itaylevyofficial/49-register-error-handling to main June 13, 2023 14:32
@ItayLevyOfficial ItayLevyOfficial force-pushed the itaylevyofficial/54-configurable-hub branch from e0d67b6 to ddc6404 Compare June 13, 2023 15:32
@ItayLevyOfficial ItayLevyOfficial marked this pull request as ready for review June 13, 2023 15:33
@ItayLevyOfficial ItayLevyOfficial requested a review from a team as a code owner June 13, 2023 15:33
@ItayLevyOfficial ItayLevyOfficial merged commit 862aecb into main Jun 14, 2023
@ItayLevyOfficial ItayLevyOfficial deleted the itaylevyofficial/54-configurable-hub branch June 14, 2023 10:34
This was referenced Sep 18, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omritoptix omritoptix omritoptix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the hub configurable between devnet and mainnet
2 participants
@ItayLevyOfficial @omritoptix