Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Enhance error handling for 'roller register' common flows #53

Merged
merged 6 commits into from
Jun 13, 2023
Merged

fix: Enhance error handling for 'roller register' common flows #53

merged 6 commits into from
Jun 13, 2023

Conversation

ItayLevyOfficial
Copy link
Contributor

@ItayLevyOfficial ItayLevyOfficial commented Jun 8, 2023 •
edited
Loading

PR Standards

Opening a pull request should be able to meet the following requirements

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@ItayLevyOfficial ItayLevyOfficial changed the title Implemented error handling for roller register feat: Implemented error handling for roller register Jun 8, 2023
@ItayLevyOfficial ItayLevyOfficial linked an issue Jun 8, 2023 that may be closed by this pull request
Implement error handling for roller register #49
Closed
@ItayLevyOfficial ItayLevyOfficial marked this pull request as ready for review June 8, 2023 15:13
@ItayLevyOfficial ItayLevyOfficial requested a review from a team as a code owner June 8, 2023 15:13
@ItayLevyOfficial ItayLevyOfficial marked this pull request as draft June 8, 2023 15:36
@ItayLevyOfficial ItayLevyOfficial changed the title feat: Implemented error handling for roller register fix: Provide clear error messages for roller register common flows Jun 11, 2023
@ItayLevyOfficial ItayLevyOfficial changed the title fix: Provide clear error messages for roller register common flows fix: Enhance error handling for 'roller register' common flows Jun 11, 2023
Base automatically changed from itaylevyofficial/16-register to main June 12, 2023 10:21
@ItayLevyOfficial ItayLevyOfficial force-pushed the itaylevyofficial/49-register-error-handling branch from 391985a to 22bd39c Compare June 12, 2023 10:37
@ItayLevyOfficial ItayLevyOfficial marked this pull request as ready for review June 12, 2023 10:38
omritoptix
omritoptix reviewed Jun 13, 2023
View reviewed changes
cmd/register/register.go Outdated Show resolved Hide resolved
cmd/register/register.go Outdated Show resolved Hide resolved
@ItayLevyOfficial ItayLevyOfficial merged commit b0c360d into main Jun 13, 2023
@ItayLevyOfficial ItayLevyOfficial deleted the itaylevyofficial/49-register-error-handling branch June 13, 2023 14:32
This was referenced Sep 18, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omritoptix omritoptix omritoptix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement error handling for roller register
2 participants
@ItayLevyOfficial @omritoptix