Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent generate new avail seed in roller migrate #517

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

ItayLevyOfficial
Copy link
Contributor

@ItayLevyOfficial ItayLevyOfficial commented Sep 6, 2023

When updating the DA config in the v0.1.12 migrate, we first created a newAvail and then moved the avail config file to the new location. This caused generating a new avail seed and saving it only in the dymint.toml config.

PR Standards

Opening a pull request should be able to meet the following requirements


For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@ItayLevyOfficial ItayLevyOfficial linked an issue Sep 6, 2023 that may be closed by this pull request
@ItayLevyOfficial ItayLevyOfficial marked this pull request as ready for review September 6, 2023 11:13
@ItayLevyOfficial ItayLevyOfficial requested a review from a team as a code owner September 6, 2023 11:13
@ItayLevyOfficial ItayLevyOfficial merged commit ecfe396 into main Sep 6, 2023
3 checks passed
@ItayLevyOfficial ItayLevyOfficial deleted the itaylevyofficial/515-avail-keys branch September 6, 2023 11:16
@VictorTrustyDev
Copy link
Contributor

@ItayLevyOfficial how about a migration correct data for users which having the same issue? Is that necessary?

@ItayLevyOfficial
Copy link
Contributor Author

@VictorTrustyDev we thought about it and decided it is unnecessary for now, since the new release was available only for a small amount of users and they can overcome it with roller config set da local

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix keys mismatch when using avail
3 participants