Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed connection-id missing key would cause relayer start to fail #503

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

omritoptix
Copy link
Collaborator

@omritoptix omritoptix commented Sep 5, 2023

PR Standards

Opening a pull request should be able to meet the following requirements


For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@omritoptix omritoptix requested a review from a team as a code owner September 5, 2023 15:12
@omritoptix omritoptix merged commit 186c275 into main Sep 5, 2023
2 of 3 checks passed
@omritoptix omritoptix deleted the omritoptix/502-fix-connection-id-key-not-found branch September 5, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roller assumes connection-id field exists when checking for existing channels
2 participants