Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add command to register rollapps #50

Merged
merged 5 commits into from
Jun 12, 2023
Merged

feat: Add command to register rollapps #50

merged 5 commits into from
Jun 12, 2023

Conversation

ItayLevyOfficial
Copy link
Contributor

@ItayLevyOfficial ItayLevyOfficial commented Jun 7, 2023 •
edited
Loading

PR Standards

Opening a pull request should be able to meet the following requirements

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@ItayLevyOfficial ItayLevyOfficial force-pushed the itaylevyofficial/16-register branch from 4798a3e to 3038fc8 Compare June 7, 2023 16:56
@ItayLevyOfficial ItayLevyOfficial force-pushed the itaylevyofficial/43-unique-rollapp-id branch from b194e6d to 85a56be Compare June 8, 2023 08:34
Base automatically changed from itaylevyofficial/43-unique-rollapp-id to main June 8, 2023 13:41
@ItayLevyOfficial ItayLevyOfficial force-pushed the itaylevyofficial/16-register branch from 3038fc8 to a091042 Compare June 8, 2023 14:10
@ItayLevyOfficial ItayLevyOfficial changed the title Implemented roller register command feat: roller register command Jun 8, 2023
@ItayLevyOfficial ItayLevyOfficial linked an issue Jun 8, 2023 that may be closed by this pull request
Implement the roller register command #16
Closed
@ItayLevyOfficial ItayLevyOfficial marked this pull request as ready for review June 8, 2023 14:15
@ItayLevyOfficial ItayLevyOfficial requested a review from a team as a code owner June 8, 2023 14:15
@omritoptix omritoptix changed the title feat: roller register command feat: Ability to register rollapps using the register command Jun 11, 2023
@omritoptix omritoptix changed the title feat: Ability to register rollapps using the register command feat: Add command to register rollapps Jun 11, 2023
@omritoptix omritoptix changed the title feat: Add command to register rollapps feat: add command to register rollapps Jun 11, 2023
@omritoptix omritoptix changed the title feat: add command to register rollapps feat: add command to register rollapp Jun 11, 2023
@ItayLevyOfficial ItayLevyOfficial changed the title feat: add command to register rollapp feat: Added command to register rollapps Jun 11, 2023
omritoptix
omritoptix reviewed Jun 11, 2023
View reviewed changes
Copy link
Collaborator

@omritoptix omritoptix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I'd say to move generic utils/constants to a generic packages vs putting it in initconfig

cmd/config/init/utils.go Show resolved Hide resolved
cmd/register/register.go Outdated Show resolved Hide resolved
cmd/register/register.go Outdated Show resolved Hide resolved
@omritoptix omritoptix changed the title feat: Added command to register rollapps feat: Add command to register rollapps Jun 11, 2023
@ItayLevyOfficial ItayLevyOfficial merged commit aee609f into main Jun 12, 2023
@ItayLevyOfficial ItayLevyOfficial deleted the itaylevyofficial/16-register branch June 12, 2023 10:21
This was referenced Sep 18, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omritoptix omritoptix omritoptix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement the roller register command
2 participants
@ItayLevyOfficial @omritoptix