Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rollapp id verification #48

Merged
merged 2 commits into from
Jun 8, 2023
Merged

feat: rollapp id verification #48

merged 2 commits into from
Jun 8, 2023

Conversation

ItayLevyOfficial
Copy link
Contributor

@ItayLevyOfficial ItayLevyOfficial commented Jun 6, 2023 •
edited
Loading

PR Standards

Opening a pull request should be able to meet the following requirements

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@ItayLevyOfficial ItayLevyOfficial changed the title Itaylevyofficial/43 unique rollapp feat: Implemented unique rollapp id verification on roller config init Jun 6, 2023
@ItayLevyOfficial ItayLevyOfficial linked an issue Jun 6, 2023 that may be closed by this pull request
Validate unique rollapp id in roller config init #43
Closed
@ItayLevyOfficial ItayLevyOfficial force-pushed the itaylevyofficial/44-initial-init branch 2 times, most recently from 06cd7bc to 2065edb Compare June 8, 2023 08:21
Base automatically changed from itaylevyofficial/44-initial-init to main June 8, 2023 08:22
@ItayLevyOfficial ItayLevyOfficial force-pushed the itaylevyofficial/43-unique-rollapp-id branch from b194e6d to 85a56be Compare June 8, 2023 08:34
@ItayLevyOfficial ItayLevyOfficial marked this pull request as ready for review June 8, 2023 08:36
@ItayLevyOfficial ItayLevyOfficial requested a review from a team as a code owner June 8, 2023 08:37
@omritoptix omritoptix changed the title feat: Implemented unique rollapp id verification on roller config init feat: Implemented unique rollapp id verification Jun 8, 2023
@omritoptix omritoptix changed the title feat: Implemented unique rollapp id verification feat: rollapp id verification Jun 8, 2023
omritoptix
omritoptix approved these changes Jun 8, 2023
View reviewed changes
cmd/config/init/unique_rollapp_id.go
)

func isRollappIDUnique(rollappID string) (bool, error) {
url := HubData.API_URL + "/dymensionxyz/dymension/rollapp/rollapp/" + rollappID
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in case this url will be used again I suggest taking it out to a const name rollapp_endpoint or something along those lines.

@ItayLevyOfficial ItayLevyOfficial merged commit 3b171b7 into main Jun 8, 2023
@ItayLevyOfficial ItayLevyOfficial deleted the itaylevyofficial/43-unique-rollapp-id branch June 8, 2023 13:41
This was referenced Sep 18, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omritoptix omritoptix omritoptix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate unique rollapp id in roller config init
2 participants
@ItayLevyOfficial @omritoptix