Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implemented rerun handling logic for roller config init #31

Merged
merged 3 commits into from
Jun 6, 2023
Merged

feat: Implemented rerun handling logic for roller config init #31

merged 3 commits into from
Jun 6, 2023

Conversation

ItayLevyOfficial
Copy link
Contributor

@ItayLevyOfficial ItayLevyOfficial commented Jun 5, 2023 •
edited
Loading

PR Standards

Opening a pull request should be able to meet the following requirements

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@ItayLevyOfficial ItayLevyOfficial changed the title Implemented rerun handling logic for roller config init feat: Implemented rerun handling logic for roller config init Jun 5, 2023
@ItayLevyOfficial ItayLevyOfficial linked an issue Jun 5, 2023 that may be closed by this pull request
Ensure Idempotency for roller config init #30
Closed
Base automatically changed from itaylevyofficial/15-init-integration-tests to main June 5, 2023 16:35
@ItayLevyOfficial ItayLevyOfficial force-pushed the itaylevyofficial/30-init-idempotancy branch from d922be8 to 81dc13f Compare June 5, 2023 16:49
@ItayLevyOfficial ItayLevyOfficial force-pushed the itaylevyofficial/30-init-idempotancy branch from 81dc13f to fac8ada Compare June 5, 2023 16:55
@ItayLevyOfficial ItayLevyOfficial marked this pull request as ready for review June 5, 2023 16:56
@ItayLevyOfficial ItayLevyOfficial requested a review from a team as a code owner June 5, 2023 16:56
omritoptix
omritoptix reviewed Jun 5, 2023
View reviewed changes
cmd/config/init/error_handler.go Outdated Show resolved Hide resolved
cmd/config/init/flags.go Outdated Show resolved Hide resolved
cmd/config/init/init.go Outdated Show resolved Hide resolved
omritoptix
omritoptix reviewed Jun 6, 2023
View reviewed changes
cmd/config/init/init.go Outdated
@@ -20,16 +20,16 @@ func InitCmd() *cobra.Command {
Short: "Initialize a rollapp configuration on your local machine.",
Run: func(cmd *cobra.Command, args []string) {
initConfig := getInitConfig(cmd, args)
overwrite, err := prepareDirectory(initConfig.Home)
handleError(err)
overwrite, err := cleanHomeDir(initConfig.Home)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for me overwrite returned from cleanHomeDir in unclear. also it seems like if the directory is clean, overwrite return true which IMO is counter intuitive.

@ItayLevyOfficial ItayLevyOfficial merged commit 8171c61 into main Jun 6, 2023
@ItayLevyOfficial ItayLevyOfficial deleted the itaylevyofficial/30-init-idempotancy branch June 6, 2023 13:27
This was referenced Sep 18, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omritoptix omritoptix omritoptix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure Idempotency for roller config init
2 participants
@ItayLevyOfficial @omritoptix