Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Build CD flow roller from the release tag #277

Merged
merged 3 commits into from
Jul 16, 2023
Merged

Fix: Build CD flow roller from the release tag #277

merged 3 commits into from
Jul 16, 2023

Conversation

ItayLevyOfficial
Copy link
Contributor

@ItayLevyOfficial ItayLevyOfficial commented Jul 16, 2023 •
edited
Loading

PR Standards

Opening a pull request should be able to meet the following requirements

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@ItayLevyOfficial ItayLevyOfficial linked an issue Jul 16, 2023 that may be closed by this pull request
cd flow not check out the latest release tag #276
Closed
@ItayLevyOfficial ItayLevyOfficial marked this pull request as ready for review July 16, 2023 10:31
@ItayLevyOfficial ItayLevyOfficial requested a review from a team as a code owner July 16, 2023 10:31
omritoptix
omritoptix reviewed Jul 16, 2023
View reviewed changes
compile_locally.sh
BINARYNAME=("dymd" "rly" "roller" "rollapp_evm")
PROJECTS=("dymension" "dymension-relayer" "dymension-rdk")
REPOS=("" "" "")
VERSIONS=("v1.0.0-rc2" "" "v0.4.0-rc2")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make the versions it use github workflow environments so we won't have to hardcode it?
https://docs.github.com/en/actions/learn-github-actions/variables

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but hardcoding gives us a clear git history of versions used - that's invaluable for debugging and rollback. Updating environment variables doesn't offer that. wdyt?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the workflow log will contain the relevant vars used so we can track that. but not critical for now.

@ItayLevyOfficial ItayLevyOfficial merged commit 56ac9b7 into main Jul 16, 2023
@ItayLevyOfficial ItayLevyOfficial deleted the itaylevyofficial/276-cd-flow-tag branch July 16, 2023 14:48
This was referenced Sep 18, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omritoptix omritoptix omritoptix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cd flow not check out the latest release tag
2 participants
@ItayLevyOfficial @omritoptix