Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Automatically Create and Upload Assets for New Releases #268

Merged
merged 2 commits into from
Jul 13, 2023
Merged

feat: Automatically Create and Upload Assets for New Releases #268

merged 2 commits into from
Jul 13, 2023
+114 −1

Conversation

ItayLevyOfficial
Copy link
Contributor

@ItayLevyOfficial ItayLevyOfficial commented Jul 13, 2023 •
edited
Loading

PR Standards

Opening a pull request should be able to meet the following requirements

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@ItayLevyOfficial ItayLevyOfficial changed the title feat: Add automatic asset creation and uploading upon new release. feat: Automatically Create and Upload Assets for New Releases Jul 13, 2023
@ItayLevyOfficial ItayLevyOfficial linked an issue Jul 13, 2023 that may be closed by this pull request
Build mac amd release archive upon new release automatically #236
Closed
@ItayLevyOfficial ItayLevyOfficial marked this pull request as ready for review July 13, 2023 11:33
@ItayLevyOfficial ItayLevyOfficial requested a review from a team as a code owner July 13, 2023 11:33
omritoptix
omritoptix reviewed Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@omritoptix omritoptix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO better to call it 'build' vs 'mac_amd_build' as it will use us to all of our builds and currently seems like it's building also for linux.

@ItayLevyOfficial ItayLevyOfficial merged commit 0318e54 into main Jul 13, 2023
@ItayLevyOfficial ItayLevyOfficial deleted the itaylevyofficial/236-cd-flow branch July 13, 2023 14:11
This was referenced Sep 18, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omritoptix omritoptix omritoptix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build mac amd release archive upon new release automatically
2 participants
@ItayLevyOfficial @omritoptix