feat: install script compiles all dependencies locally #211
Conversation
| GO_REQUIRED_VERSION="1.19" | ||
| display_go_installation_instructions() { | ||
| echo "$EMOJI To install Go $GO_REQUIRED_VERSION, you can run the following commands:" | ||
| echo " wget https://go.dev/dl/go1.19.10.${OS}-${ARCH}.tar.gz" |
There was a problem hiding this comment.
@shaolin-flow add wget as a requirement for the docs
| IFS=' ' read -r -a binary_array <<< "${BINARYNAME[i]}" # convert string to array | ||
| binary=${binary_array[0]} # get the first element | ||
| echo "$EMOJI checking for $binary..." | ||
| if [ -x "$(command -v "$binary")" ]; then |
There was a problem hiding this comment.
No need for that - if the binary not exist in the roller path, we want to install it. this will cause versioning problems
There was a problem hiding this comment.
Or verify the binary version as well
There was a problem hiding this comment.
but if the binary does exist, I'm want to let the user know it's gonna be overridden
| fi | ||
|
|
||
| for binary in ${BINARYNAME[i]}; do | ||
| binary_path=$(which "$binary" 2> /dev/null) # Redirect error output to /dev/null |
There was a problem hiding this comment.
problematic again. the user may have both the standard and the dymension relayer on the same machine
There was a problem hiding this comment.
in this case the user had the option to use the existing one or overwrite
install.sh
Outdated
| sudo mv "/tmp/roller_tmp/roller_bins/lib"/* "$INTERNAL_DIR" | ||
| sudo mv "/tmp/roller_tmp/roller_bins/roller" "$ROLLER_BIN_PATH" | ||
| sudo mv "/tmp/roller_tmp/roller_bins/rollapp_evm" "$ROLLAPP_EVM_PATH" # move the rollapp_evm binary | ||
| if ! sudo curl -L "$TGZ_URL" --progress-bar | sudo tar -xz -C "/tmp/roller_tmp"; then |
There was a problem hiding this comment.
Consider removing the negation operator (!) from the condition check and flipping the logic inside the if block.
mtsitrin
deleted the
mtsitrin/207-install-script-should-attempt-to-build-locally-if-release-not-found
branch
PR Standards
Opening a pull request should be able to meet the following requirements
For Author:
godoccommentsFor Reviewer:
After reviewer approval: