Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fix balance printing in roller run #193

Merged
merged 23 commits into from
Jul 5, 2023
Merged

feat: fix balance printing in roller run #193

merged 23 commits into from
Jul 5, 2023

Conversation

mtsitrin
Copy link
Contributor

@mtsitrin mtsitrin commented Jul 4, 2023

PR Standards

Opening a pull request should be able to meet the following requirements

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

mtsitrin added 21 commits July 4, 2023 09:22
@mtsitrin
removed roller binary from source
32666bd
@mtsitrin
updated interactive flow
871a1f2
@mtsitrin
renamed SDK to custom
f32448b
@mtsitrin
fixed denom setting on interactive and added validation
19c0461
@mtsitrin
go mod tidy
a21acda
@mtsitrin
added config package outside the cmd package
ace22ff
@mtsitrin
refactored usage logging. fixed da setting in the interactive
2187e54
@mtsitrin
implemented data layer interface. implemented celestia as interface
95929cf
@mtsitrin
added mock support to init flow and da_light_client
392b130
@mtsitrin
fixed sequencer start with mock
b0a5972
@mtsitrin
Revert "feat: Add loading spinner with status on roller init, registe…
e5ccda2 
…r and run (#166)"

This reverts commit 63d166d.
@mtsitrin
added hack to support run command output with mockDA
ccadcc5
@mtsitrin
removed spinner from run command
e8a214c 
This reverts commit e5ccda2.
@mtsitrin
Merge remote-tracking branch 'origin/main' into mtsitrin/165-add-supp…
af351cb 
…ort-for-mock-da
@mtsitrin
using case insensetive when selecting DA
236a378
@mtsitrin
fixed spinner on interactive flow
573fcfb
@mtsitrin
When rendering UI, DA light client is optional
f6e82d1
@mtsitrin
moved service manager to seperate package
19b1f32
@mtsitrin
finished refactoring the service manager
2c49810
@mtsitrin
Merge remote-tracking branch 'origin/main' into mtsitrin/179-rollers-…
57a5714 
…service-output-should-be-generalised-for-da-layer
@mtsitrin
added denoms to balance printing
1906634
@mtsitrin mtsitrin requested a review from a team as a code owner July 4, 2023 18:01
@mtsitrin mtsitrin linked an issue Jul 4, 2023 that may be closed by this pull request
fix balance printing in roller run #187
Closed
@mtsitrin mtsitrin force-pushed the mtsitrin/187-fix-balance-printing-in-roller-run branch from ae20a04 to 1246f17 Compare July 4, 2023 18:37
ItayLevyOfficial
ItayLevyOfficial approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@ItayLevyOfficial ItayLevyOfficial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cmd/utils/balance.go
return b.Amount.String() + b.Denom
}

type resp struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
type resp struct {
type balanceResp struct {

@mtsitrin mtsitrin merged commit 969670b into main Jul 5, 2023
@mtsitrin mtsitrin deleted the mtsitrin/187-fix-balance-printing-in-roller-run branch July 5, 2023 11:40
@github-actions github-actions bot mentioned this pull request Sep 18, 2024
Closed
This was referenced Sep 19, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItayLevyOfficial ItayLevyOfficial ItayLevyOfficial approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix balance printing in roller run
2 participants
@mtsitrin @ItayLevyOfficial