Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Initializing relayer configuration from roller config init #19

Merged
merged 16 commits into from
Jun 4, 2023
Merged

feat: Initializing relayer configuration from roller config init #19

merged 16 commits into from
Jun 4, 2023

Conversation

ItayLevyOfficial
Copy link
Contributor

@ItayLevyOfficial ItayLevyOfficial commented May 31, 2023 •
edited
Loading

PR Standards

Opening a pull request should be able to meet the following requirements

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@ItayLevyOfficial ItayLevyOfficial linked an issue May 31, 2023 that may be closed by this pull request
Implement Roller Config Init to Auto-Generate Relayer Configuration Files #14
Closed
@ItayLevyOfficial ItayLevyOfficial changed the title Itaylevyofficial/14 relayer configuration feat: Initializing relayer configuration from roller config init May 31, 2023
@ItayLevyOfficial ItayLevyOfficial changed the base branch from main to itaylevyofficial/11-light-client-configuration May 31, 2023 12:07
@ItayLevyOfficial ItayLevyOfficial marked this pull request as ready for review May 31, 2023 12:23
@ItayLevyOfficial ItayLevyOfficial requested a review from a team as a code owner May 31, 2023 12:23
omritoptix
omritoptix reviewed Jun 2, 2023
View reviewed changes
Copy link
Collaborator

@omritoptix omritoptix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that you are trying to merge the current branch to a light-node configuration branch which IMO is confusing.

Branches should be merged to a high level branches, so for example if it's part of a bigger feature (config init) feature, it should be merged there. Especially when there are multiple PRS open it's hard to keep track which is the latest and which merges to which.

cmd/config/init/consts.go Show resolved Hide resolved
cmd/config/init/init.go Show resolved Hide resolved
cmd/config/init/init.go Show resolved Hide resolved
Base automatically changed from itaylevyofficial/11-light-client-configuration to main June 4, 2023 08:16
@ItayLevyOfficial ItayLevyOfficial merged commit c934949 into main Jun 4, 2023
@ItayLevyOfficial ItayLevyOfficial deleted the itaylevyofficial/14-relayer-configuration branch June 4, 2023 09:16
This was referenced Sep 18, 2024
Closed
Closed
This was referenced Sep 19, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omritoptix omritoptix omritoptix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Roller Config Init to Auto-Generate Relayer Configuration Files
2 participants
@ItayLevyOfficial @omritoptix