Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roller's service output should be generalised for DA layer #179

Closed
mtsitrin opened this issue Jul 4, 2023 · 1 comment · Fixed by #184
Closed

roller's service output should be generalised for DA layer #179

mtsitrin opened this issue Jul 4, 2023 · 1 comment · Fixed by #184
Assignees
@mtsitrin
Labels
C:da enhancement New feature or request

Comments

@mtsitrin
Copy link
Contributor

mtsitrin commented Jul 4, 2023

Currenly the run command uses some service status logic for rendering it's output

The code is tangled and uses many hardcoded values (e.g Celetia)

The code needs to be:

  • restricted with ServiceManager module
  • render the DA according to it's type, using data_layer interface
@mtsitrin mtsitrin added C:da enhancement New feature or request labels Jul 4, 2023
@mtsitrin mtsitrin self-assigned this Jul 4, 2023
@mtsitrin
Copy link
Contributor Author

mtsitrin commented Jul 4, 2023

it's blocking #76

This was referenced Jul 4, 2023
Closed
Closed
@mtsitrin mtsitrin linked a pull request Jul 4, 2023 that will close this issue
feat: roller service output should be generalised for da layer #184
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mtsitrin mtsitrin

Labels
C:da enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: roller service output should be generalised for da layer dymensionxyz/roller
1 participant
@mtsitrin