Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Continuous Status Monitoring for DA LC and sequencer #137

Merged
merged 3 commits into from
Jul 2, 2023
Merged

feat: Add Continuous Status Monitoring for DA LC and sequencer #137

merged 3 commits into from
Jul 2, 2023

Conversation

ItayLevyOfficial
Copy link
Contributor

@ItayLevyOfficial ItayLevyOfficial commented Jun 29, 2023 •
edited
Loading

PR Standards

Opening a pull request should be able to meet the following requirements

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@ItayLevyOfficial ItayLevyOfficial changed the title Itaylevyofficial/101 run status feat: Add services auto fetched status to roller run Jun 29, 2023
@ItayLevyOfficial ItayLevyOfficial changed the title feat: Add services auto fetched status to roller run feat: Add Continuous Status Monitoring for DA LC and sequencer in Roller Run Command Jun 29, 2023
@ItayLevyOfficial ItayLevyOfficial force-pushed the itaylevyofficial/101-run-status branch from 9cc90d2 to ab90223 Compare June 29, 2023 09:03
@ItayLevyOfficial ItayLevyOfficial linked an issue Jun 29, 2023 that may be closed by this pull request
Add current services status on roller run - da & sequencer #101
Closed
@ItayLevyOfficial ItayLevyOfficial marked this pull request as ready for review June 29, 2023 09:04
@ItayLevyOfficial ItayLevyOfficial requested a review from a team as a code owner June 29, 2023 09:04
@ItayLevyOfficial ItayLevyOfficial marked this pull request as draft June 29, 2023 10:33
@ItayLevyOfficial ItayLevyOfficial force-pushed the itaylevyofficial/101-run-status branch from 25aeb43 to c839817 Compare June 29, 2023 11:11
@ItayLevyOfficial ItayLevyOfficial marked this pull request as ready for review June 29, 2023 11:11
@ItayLevyOfficial ItayLevyOfficial marked this pull request as draft June 29, 2023 11:12
@ItayLevyOfficial ItayLevyOfficial force-pushed the itaylevyofficial/101-run-status branch from c839817 to 70fc7d0 Compare June 29, 2023 11:18
@ItayLevyOfficial ItayLevyOfficial marked this pull request as ready for review June 29, 2023 11:19
mtsitrin
mtsitrin approved these changes Jun 29, 2023
View reviewed changes
.gitignore Outdated
@@ -1,4 +1,7 @@
/.vscode
build/
*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are more precise rules other than *

@ItayLevyOfficial ItayLevyOfficial requested a review from mtsitrin July 2, 2023 07:25
@ItayLevyOfficial ItayLevyOfficial force-pushed the itaylevyofficial/101-run-status branch from 3ff805b to 337ab5d Compare July 2, 2023 08:26
@omritoptix omritoptix changed the title feat: Add Continuous Status Monitoring for DA LC and sequencer in Roller Run Command feat: Add Continuous Status Monitoring for DA LC and sequencer Jul 2, 2023
@ItayLevyOfficial ItayLevyOfficial merged commit de39ccb into main Jul 2, 2023
@ItayLevyOfficial ItayLevyOfficial deleted the itaylevyofficial/101-run-status branch July 2, 2023 08:49
This was referenced Sep 18, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtsitrin mtsitrin mtsitrin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add current services status on roller run - da & sequencer
2 participants
@ItayLevyOfficial @mtsitrin