-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fork): drs upgrade when multiple forks fix #1266
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srene
changed the title
fix(fork): fix stop condition + dont load from instruction
fix(fork): stop condition + drs fork bug fix
Dec 5, 2024
srene
changed the title
fix(fork): stop condition + drs fork bug fix
fix(fork): drs upgrade when multiple forks fix
Dec 5, 2024
omritoptix
approved these changes
Dec 8, 2024
@@ -229,28 +228,40 @@ func (m *Manager) submitForkBatch(height uint64) error { | |||
// updateStateWhenFork updates dymint state in case fork is detected | |||
func (m *Manager) updateStateWhenFork() error { | |||
// in case fork is detected dymint state needs to be updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redundant comment as it doesn't add anything on top of the function godoc.
we should strive to have more reasoning in our comments, not just explaining what we do (but why we do it).
needs to be updated because..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Standards
The objective of this PR is to fix detected issues in forking process:
Opening a pull request should be able to meet the following requirements
--
PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A
Close #1268, #1267
<-- Briefly describe the content of this pull request -->
For Author:
godoc
commentsFor Reviewer:
After reviewer approval: