Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple AccumulatedData in case of submission latency #954

Closed
mtsitrin opened this issue Jul 16, 2024 · 1 comment · Fixed by #960
Closed

multiple AccumulatedData in case of submission latency #954

mtsitrin opened this issue Jul 16, 2024 · 1 comment · Fixed by #960
Assignees

Comments

@mtsitrin
Copy link
Contributor

The AccumulatedBatchSize is cleared on submission iteration.

When m.AccumulatedBatchSize has reached the max, it will trigger toSubmit event for each subsequent block, until the submission handler iterates again.

@danwt
Copy link
Contributor

danwt commented Jul 18, 2024

In other words:
there is a loop which tracks accumulated data and submits signals whenever the accumulated mount is exceeded, but the counter is is not set to zero when submitting the signal, but rather, when consuming it, which is wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants