Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WorkshopId should be ulong not long? #153

Closed
originalfoo opened this issue Aug 10, 2018 · 3 comments
Closed

WorkshopId should be ulong not long? #153

originalfoo opened this issue Aug 10, 2018 · 3 comments
Labels
question Further information is requested

Comments

@originalfoo
Copy link

In RealTimeMod.cs:

private const long WorkshopId = 1420955187;

But later in the file:

        private static string GetModPath()
        {
            PluginManager.PluginInfo pluginInfo = PluginManager.instance.GetPluginsInfo()
                .FirstOrDefault(pi => pi.publishedFileID.AsUInt64 == WorkshopId);

            return pluginInfo?.modPath;
        }

You're comparing to pi.publishedFileID.AsUInt64 - so shouldn't WorkshopId be a ulong?

@dymanoid
Copy link
Owner

For commenting the code, please use direct "code comment" feature, not "issues". You can open the source code in the GitHub web view and add your comments directly to the corresponding code lines.

Please move your question there and close the issue.

@dymanoid dymanoid added the question Further information is requested label Aug 10, 2018
@originalfoo
Copy link
Author

originalfoo commented Aug 10, 2018

What's the specific procedure? I don't see a direct option to comment, but if I select the line of code I see option to create new issue relating to that line (although on doing so I didn't see any clear indication the issue would be linked to the code)? Or should I track down the commit that added that line and comment there?

See also: isaacs/github#284

@dymanoid
Copy link
Owner

dymanoid commented Aug 10, 2018

Yeah, that's not so straight forward. The comments are available for commits only, not for the plain code view.

  • Open the file in the GitHub source view.
  • Pick the line of interest and choose "View git blame".
  • On the left, pick a commit that changes the line of interest an click on that commit.
  • In the commit, find the line and hover the mouse cursor over it - a blue plus symbol appears. That's the "add comment" button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants