Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance tests should be default for each type #56

Open
sbrugman opened this issue May 8, 2020 · 1 comment
Open

Performance tests should be default for each type #56

sbrugman opened this issue May 8, 2020 · 1 comment
Labels
enhancement New feature or request performance Things should be fast tests Always test your code

Comments

@sbrugman
Copy link
Contributor

sbrugman commented May 8, 2020

As a developer I want to make sure that type inference is performant for new and chaning types. We benchmark our critical functions for that locally now. It would be better to explicitly include this in the tests. This is beneficial to ensure the performance of types and encourages developers to always test performance. The added workload is neglectible, as performance testing should already be part of the normal workflow.

@sbrugman sbrugman added enhancement New feature or request tests Always test your code performance Things should be fast labels May 8, 2020
@ieaves
Copy link
Collaborator

ieaves commented May 14, 2020

  • Include big_O in performance testing results
  • extend performance testing to relations
  • extend coverage for test suite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request performance Things should be fast tests Always test your code
Projects
None yet
Development

No branches or pull requests

2 participants