Skip to content

Refactor button + Add new semantic mode and/or Create New Component #2028

Closed Answered by GomezIvann
irenevera asked this question in General
Discussion options

You must be logged in to vote

Technical approach

To incorporate this use case into the current DxcButton I propose two things:

  • New prop semantic. Defines the semantic character of the component. Values: "error", "default", "valid", etc.
  • Change the API of the size prop. Now it would become an object and allow to set both width (current values: "small", "medium") and height ("s" or "small", "m" or "medium", etc).

A coded example would be:

<DxcButton 
	label="Submit"
	size={
		height: "s"
		width: "medium",
	}
	semantic="error" // "valid", "default"
	mode="secondary"
/>

Replies: 2 comments

Comment options

You must be logged in to vote
0 replies
Answer selected by GomezIvann
Comment options

You must be logged in to vote
0 replies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants