Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

Hard-coded user.email value in Changelog code causes git push failure #710

Closed
bjanderson70 opened this issue Sep 27, 2021 · 1 comment · Fixed by #711
Closed

Hard-coded user.email value in Changelog code causes git push failure #710

bjanderson70 opened this issue Sep 27, 2021 · 1 comment · Fixed by #711
Assignees
Labels
bug Something isn't working

Comments

@bjanderson70
Copy link

Describe the bug
Using sfpowerscript in a GitHub + Jenkins environment fails to push to the "changelog" when using generatechangelog

I can release except error w/ pushing to changeLog ; the internal system I am on checks the user's email (as valid) ... When I dug a bit deeper into this I noticed in changelog/ChangelogImpl.ts:pushChangelogToBranch sets the user.name to "sfpowerscripts" and user.email to "sfpowerscripts@dxscale" ... this is causing the failure.

Customer runs checkemail anytime a push occurs (not possible to disable)

To Reproduce
Steps to reproduce the behavior:
Using the latest DockerImage . Run script (bash) in Jenkins

sfdx sfpowerscripts:orchestrator:release .... --generatechangelog --branchname changelog

Expected behavior
A clear and concise description of what you expected to happen.
Changelog with pushed release information

Screenshots
If applicable, add screenshots to help explain your problem.

Platform Details (please complete the following information):

  • OS: Mac Big Sur 11.5.2
  • Version [e.g. CLI Version eg: 1.6.6] What's in the current Docker image
  • Salesforce CLI(sfdx cli) Version: [7.110.0]
  • CI Platform: GitHub + Jenkins

Additional context
Add any other context about the problem here.
All is fine if I do not use --generatechangelog --branchname

@azlam-abdulsalam azlam-abdulsalam added the bug Something isn't working label Sep 27, 2021
@azlam-abdulsalam azlam-abdulsalam added this to the Release - October 21 milestone Sep 27, 2021
@azlam-abdulsalam
Copy link
Contributor

@aly76 Lets utilise an env variable for this one?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants