Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

Validate Against Org flag to rerun validation even if no changes are detected #680

Closed
rrgripp opened this issue Sep 1, 2021 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@rrgripp
Copy link

rrgripp commented Sep 1, 2021

Sometimes our Gitlab pipeline fails to complete during the sandbox validation job for various reasons (timeouts for instance), and when we try to rerun the job, we get the message validate will only execute if there is a change in atleast one of the packages.

It would be interesting to have a flag that allows us to rerun the sfdx sfpowerscripts:orchestrator:validateAgainstOrg command, even if no changes were detected in the packages.

@azlam-abdulsalam
Copy link
Contributor

@rrgripp Can you explain the scenario further? If a particular package in a collection of packages fail, and some of them got deployed, we will redo the remaining if you retrigger.

Is there something where you went ahead discarding the output of validateAgainstOrg and went to publish?

@rrgripp
Copy link
Author

rrgripp commented Sep 9, 2021

Since we already have some source code in the happy soup, sometimes the test fails because of these files. But when I rerun the test, as there was no changes on the package source code, the test is not executed

@azlam-abdulsalam
Copy link
Contributor

In that case, it is better to remove --diffcheck option. Will that help?

@rrgripp
Copy link
Author

rrgripp commented Sep 13, 2021

That would be in which command?
Currently I'm using just

sfdx sfpowerscripts:orchestrator:validateAgainstOrg -u sandbox --loglevel=$LOG_LEVEL

@azlam-abdulsalam
Copy link
Contributor

In the case of validate command, remove sfpowerscripts artifact installed in the org. We will be introducing an environment variable for this shortly

@azlam-abdulsalam azlam-abdulsalam self-assigned this Sep 17, 2021
@azlam-abdulsalam azlam-abdulsalam added the bug Something isn't working label Sep 17, 2021
@rrgripp
Copy link
Author

rrgripp commented Oct 4, 2021

Hi @azlam-abdulsalam, thanks for the reply! Yeah, I've been doing that to workaround the issue, but on the long run, it's not the ideal solution. Looking forward to this new release and what you guys have prepared for us 🙏 !

Still regarding the matter of validateAgainstOrg, I opened a new issue with a suggestion of a new flag to the command. Not sure if it relates (or becomes useless) with this new release that's coming, but I think maybe it could help with this issue.

Anyway, thanks for all the support!

@azlam-abdulsalam
Copy link
Contributor

Closing this as there is an analysis triggered on #800

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants