Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: empty item being created #361

Closed
nelsonic opened this issue Apr 24, 2023 · 1 comment
Closed

BUG: empty item being created #361

nelsonic opened this issue Apr 24, 2023 · 1 comment
Labels
bug Suspected or confirmed bug (defect) in the code chore a tedious but necessary task often paying technical debt tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written technical A technical issue that requires understanding of the code, infrastructure or dependencies user-feedback Feedback from people using the App

Comments

@nelsonic
Copy link
Member

nelsonic commented Apr 24, 2023 •
edited
Loading

while testing the MVP on localhost I keep seeing this empty item (no text)
dwyl-mvp-null-item-created

This is the record in the items table:
dwyl-mvp-null-item-person_id-2

I'm reading this line of code:

mvp/lib/app_web/live/app_live.ex

Line 61 in a95bbdc

Item.update_draft(draft, %{text: ""})

And I'm not understanding why we would ever want to save an item with text="" (empty) ... 🤷‍♂️

Note: this issue is not prioritised because I feel that it only exists because we are doing tags in a non-intuitive way ...
ref: #221 (comment)
i.e. the problem of saving a blank item is a symptom of the root cause: incoherent experience.
And it's 100% my "fault". So I will fix it. 👌
@nelsonic nelsonic added bug Suspected or confirmed bug (defect) in the code technical A technical issue that requires understanding of the code, infrastructure or dependencies user-feedback Feedback from people using the App chore a tedious but necessary task often paying technical debt tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written labels Apr 24, 2023
@nelsonic nelsonic moved this to 🔖 Ready for Development in dwyl app kanban Apr 25, 2023
@nelsonic nelsonic moved this from 🔖 Ready for Development to 📋 Backlog in dwyl app kanban Apr 25, 2023
@nelsonic
Copy link
Member Author

No longer seeing this issue so closing. If I see it again will re-open. 👌

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in dwyl app kanban Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Suspected or confirmed bug (defect) in the code chore a tedious but necessary task often paying technical debt tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written technical A technical issue that requires understanding of the code, infrastructure or dependencies user-feedback Feedback from people using the App
Projects
dwyl app kanban
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nelsonic