Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Fix GH pages deploy. #8

Merged
merged 3 commits into from
Aug 15, 2024
Merged

[PR] Fix GH pages deploy. #8

merged 3 commits into from
Aug 15, 2024

Conversation

LuchoTurtle
Copy link
Member

Fixes the Github Pages deploy and the analytics script configuration.

@LuchoTurtle LuchoTurtle added bug Suspected or confirmed bug (defect) in the code in-progress An issue or pull request that is being worked on by the assigned person labels Aug 15, 2024
@LuchoTurtle LuchoTurtle self-assigned this Aug 15, 2024
@LuchoTurtle LuchoTurtle merged commit 97ef7fa into main Aug 15, 2024
@LuchoTurtle LuchoTurtle deleted the fix-gb-pages-deploy branch August 15, 2024 01:21
@LuchoTurtle
Copy link
Member Author

LuchoTurtle commented Aug 15, 2024

Screenshot 2024-08-15 at 01 54 39

Simple site is deployed in https://dwyl.github.io/learn-analytics/.
Plausible dashboard is in https://analytics.dwyl.com/dwyl.github.io%2Flearn-analytics.

It's properly working.
It's worth noting that the simple website does not have script proxying (Next.js does, however). This means that if a browser is using adblocker, it may block the script, so it won't show up in the Plausible dashboard.

Check https://plausible.io/docs/proxy/introduction for more information. I didn't set up on the simple html website because:

  • I already had in the Next.js one.
  • it entails me changing DNS records and reverse proxying, but I don't have access to these with Github Pages.

But we're cool, it's documented regardless 👌

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks. 👍

P.S. try not to merge your own PRs 😉
I get it that you're testing something ... but in general. #teamwork 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Suspected or confirmed bug (defect) in the code in-progress An issue or pull request that is being worked on by the assigned person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants