Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reviewed Readme and modified HTML text #75

Merged
merged 2 commits into from
Mar 7, 2024
Merged

reviewed Readme and modified HTML text #75

merged 2 commits into from
Mar 7, 2024

Conversation

ndrean
Copy link
Collaborator

@ndrean ndrean commented Mar 6, 2024

My modifications regarding the semantic paragraph in the Readme.

@codecov Codecov
Copy link

codecov bot commented Mar 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c9985ba) to head (c28ead6).
Report is 6 commits behind head on main.

❗ Current head c28ead6 differs from pull request most recent head d5d08e9. Consider uploading reports for the commit d5d08e9 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff            @@
##              main       #75   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          198       198           
=========================================
  Hits           198       198

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

LuchoTurtle
LuchoTurtle reviewed Mar 7, 2024
View reviewed changes
lib/app_web/live/page_live.ex
@@ -135,7 +135,7 @@ defmodule AppWeb.PageLive do
# Check mime type
{:check_mime, :ok} <- {:check_mime, check_mime(mime, mimetype)},
# Get SHA1 code from the image and check it
sha1 <- App.Image.calc_sha1(file_binary),
sha1 = App.Image.calc_sha1(file_binary),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide more insight on this change? I'm not saying it's wrong, I'm just curious on why you did this (to learn more about it) :D

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, yes, forgot this. It is an assignment, not a match, so it is more correct to use = than <-. I read this somewhere.....

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. Just curious. Thanks!

@LuchoTurtle LuchoTurtle merged commit 5a97e23 into dwyl:main Mar 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuchoTurtle LuchoTurtle LuchoTurtle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndrean @LuchoTurtle