Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref workflows on RTD #199

Open
JoelPasvolsky opened this issue Sep 12, 2019 · 5 comments
Open

Ref workflows on RTD #199

JoelPasvolsky opened this issue Sep 12, 2019 · 5 comments

Comments

@JoelPasvolsky
Copy link
Contributor

Currently https://docs.ocean.dwavesys.com/projects/hybrid/en/stable/reference/reference.html mixes workflows and dimod samplers without clear distinction; for example:

  • workflow:
    image
  • sampler:
    image

What do you think about moving the dimod samplers to https://docs.ocean.dwavesys.com/projects/hybrid/en/stable/reference/samplers.html and clearly stating that workflows are workflows in the description; e.g., "An opinionated hybrid asynchronous decomposition sampler for problems of arbitrary structure and size" --> "An opinionated hybrid asynchronous decomposition workflow for problems of arbitrary structure and size. "

@randomir
Copy link
Member

I don't think dimod samplers should live in the page with hybrid samplers (workflows).

Dimod samplers that wrap hybrid workflows/samplers can all trivially be replaced with hybrid.HybridSampler around the workflows, and they exist merely for convenience to users used to dimod samplers.

I believe documentation should group entities by function, not syntax. Hence, Kerberos workflow sampler and Kerberos dimod sampler should sit next to each other. Similarly for PT, PA, etc.

@JoelPasvolsky
Copy link
Contributor Author

Going with your preference, we should at least make that clearly stick out - I was scrolling down and at first I thought it was a mistake that Kerberos was repeated. We want non-expert users to find it simple to plug in Kerberos as a minimum-thought sampler and for such users the differences on the RTD page might be a bit subtle.

@randomir
Copy link
Member

Maybe it's enough to just link to it from the intro page, when you introduce the kerberos sampler?

@JoelPasvolsky
Copy link
Contributor Author

Would be nice to also to add at least a few signpost statements for users scrolling through the Reference Workflows page that the next item is a sampler. dwave-hybrid has a lot of components with its internal terminology for new users to absorb, I expect some to come here without having the difference between a workflow, hybrid sampler, and dimod samplers at the front of their minds.

@randomir
Copy link
Member

Agree. Feel free to open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants