Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bus reg letters not generating on some Grants #306

Merged
merged 2 commits into from
Sep 6, 2024
Merged

fix: bus reg letters not generating on some Grants #306

merged 2 commits into from
Sep 6, 2024

Conversation

fibble
Copy link
Contributor

@fibble fibble commented Sep 4, 2024 •
edited by jerotire
Loading

Description

Improve handling for invalid or null emails in the local_authority table

Related issue: VOL-5768

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

@fibble fibble changed the title Bus reg letters not generating vol 5768 fix: bus reg letters not generating on some Grants Sep 4, 2024
@fibble fibble force-pushed the bus-reg-letters-not-generating-vol-5768 branch from ae59ea3 to a222065 Compare September 5, 2024 07:14
@fibble fibble marked this pull request as ready for review September 5, 2024 07:20
@fibble fibble requested review from ilindsay and a team as code owners September 5, 2024 07:20
@ilindsay ilindsay merged commit 59a4007 into main Sep 6, 2024
20 of 21 checks passed
@ilindsay ilindsay deleted the bus-reg-letters-not-generating-vol-5768 branch September 6, 2024 12:31
@github-actions github-actions bot mentioned this pull request Sep 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilindsay ilindsay ilindsay approved these changes

@jerotire jerotire jerotire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fibble @jerotire @ilindsay