Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: internal modal/alert button group position and modal bottom spacing #305

Merged
merged 1 commit into from
Sep 3, 2024
Merged

fix: internal modal/alert button group position and modal bottom spacing #305

merged 1 commit into from
Sep 3, 2024

Conversation

jerotire
Copy link
Contributor

@jerotire jerotire commented Sep 3, 2024 •
edited
Loading

Description

Improvements for internal modals and alerts:

  • Remove styling for absolute positioning for .govuk-button-group
  • Removed superfluous bottom padding for the modal/alert.

Unrelated changes, are new git hooks to improve code styling being applied to changed files.

Related issue: https://dvsa.atlassian.net/browse/VOL-5734

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

@jerotire jerotire requested review from gabrielg2020 and a team as code owners September 3, 2024 15:28
@fibble fibble merged commit 47596ce into main Sep 3, 2024
18 checks passed
@fibble fibble deleted the fix/internal-modal-button-and-padding-spacing branch September 3, 2024 18:50
@github-actions github-actions bot mentioned this pull request Sep 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fibble fibble fibble approved these changes

@JoshuaLicense JoshuaLicense JoshuaLicense approved these changes

@gabrielg2020 gabrielg2020 Awaiting requested review from gabrielg2020 gabrielg2020 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jerotire @JoshuaLicense @fibble