This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
feat(branding): update crown logo to Tudor Crown logo in header #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaLicense
approved these changes
Feb 14, 2024
jerotire
pushed a commit
to dvsa/vol-app
that referenced
this pull request
Aug 16, 2024
* feat(branding): update crown logo to Tudor Crown logo in header * fixup! feat(branding): update crown logo to Tudor Crown logo in header --------- Co-authored-by: JoshuaLicense <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the branding in our
olcs-selfserveheader by replacing the existing crown logo with the new Tudor Crown logo.logo changed based on instruction given on here govuk-frontend
Changes
.phtmlfile to reflect the new GOV.UK logo.Because we are not using the Nunjucks macro, so we have to locate the HTML for the existing crown and replace it with provided updated HTML.
Related issue: https://dvsa.atlassian.net/browse/VOL-4960
Before submitting (or marking as "ready for review")