This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
test(refactored): remove servicemanager #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanakhandvsa
changed the title
JoshuaLicense
suggested changes
Feb 8, 2024
test/Olcs/src/Controller/Licence/Vehicle/SwitchBoardControllerTest.php
Outdated
Show resolved
Hide resolved
…n LoginControllerTest
…om setUp in LoginControllerTest and Remove unnecessary mock container setup in setupSut method
JoshuaLicense
approved these changes
Feb 22, 2024
fibble
approved these changes
Feb 23, 2024
jerotire
pushed a commit
to dvsa/vol-app
that referenced
this pull request
Aug 16, 2024
* test(refactor): removed servicemanager and refactored accordingly * test(refactor): removed servicemanager and refactored accordingly * test(refactor): removed servicemanager and refactored accordingly * test(refactor): removed servicemanager and refactored accordingly * test(refactor): removed servicemanager and refactored accordingly * refactor(tests): separate LoginController initialization from setUp in LoginControllerTest * refactor(tests): separate SwitchBoardControllerTest initialization from setUp in LoginControllerTest and Remove unnecessary mock container setup in setupSut method * refactor(tests): separate SessionTimeoutControllerTest initialization from setUp * refactor(tests): separate ListVehicleController initialization from setUp --------- Co-authored-by: JoshuaLicense <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored tests by removing dependency and duplication of serviceManager
Related issue: JIRA_TICKET_NUMBER
Before submitting (or marking as "ready for review")