Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

fix: Two constructor params were recently added, only one was being u… #31

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

fibble
Copy link
Contributor

@fibble fibble commented Jan 26, 2024

…sed and the other not passed in from the factory. Removed the unused one. Page now tests OK locally.

module/Olcs/src/Controller/Lva/Variation/FinancialEvidenceController.php Recently refactored adding two constructor parameters. Only one was being used and passed in from factory, other absent in factory. Removed, tested page locally. Works OK now.

Related issue: VOL-4883

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

…sed and the other not passed in from the factory. Removed the unused one. Page now tests OK locally.
@ilindsay ilindsay merged commit 3275482 into main Jan 26, 2024
3 of 6 checks passed
@ilindsay ilindsay deleted the remove-unused-constructor-depedency-vol-4883 branch January 26, 2024 09:45
jerotire pushed a commit to dvsa/vol-app that referenced this pull request Aug 16, 2024
…sed and the other not passed in from the factory. Removed the unused one. Page now tests OK locally. (dvsa/olcs-selfserve#31)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants