From 3c37393b7a78c37bdbf63cba3224142a17007edf Mon Sep 17 00:00:00 2001 From: dvirtz Date: Fri, 22 Oct 2021 17:04:39 +0300 Subject: [PATCH] ci: deprecate node 10 --- .github/workflows/build.yml | 2 +- package.json | 1 + packages/reveal-test/test/consume.test.cjs | 3 ++- yarn.lock | 2 +- 4 files changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 6cece3d..57e308b 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -11,7 +11,7 @@ jobs: strategy: matrix: - node_version: [10.x, 12.x, 14.x] + node_version: [12.x, 14.x, 16.x] steps: - uses: actions/checkout@v2 diff --git a/package.json b/package.json index e5bfb02..f670a32 100644 --- a/package.json +++ b/package.json @@ -42,6 +42,7 @@ "rollup-plugin-delete": "^2.0.0", "rollup-plugin-node-globals": "^1.4.0", "rollup-plugin-node-polyfills": "^0.2.1", + "semver": "^7.3.5", "sinon": "^9.2.4", "test-console": "^1.1.0" }, diff --git a/packages/reveal-test/test/consume.test.cjs b/packages/reveal-test/test/consume.test.cjs index 2867330..484b846 100644 --- a/packages/reveal-test/test/consume.test.cjs +++ b/packages/reveal-test/test/consume.test.cjs @@ -1,11 +1,12 @@ const { compile } = require('..'); const assert = require('assert'); +const semver = require('semver'); describe('library consumer', function () { it('can require the library', async function () { await assert.rejects(compile, { name: 'TypeError', - message: `Cannot read property 'failReason' of undefined` + message: semver.lt(process.version, '16.0.0') ? `Cannot read property 'failReason' of undefined` : `Cannot read properties of undefined (reading 'failReason')` }); }); }); diff --git a/yarn.lock b/yarn.lock index dc7282e..f243b31 100644 --- a/yarn.lock +++ b/yarn.lock @@ -6696,7 +6696,7 @@ semver@^6.0.0, semver@^6.1.2, semver@^6.2.0, semver@^6.3.0: resolved "https://registry.yarnpkg.com/semver/-/semver-6.3.0.tgz#ee0a64c8af5e8ceea67687b133761e1becbd1d3d" integrity sha512-b39TBaTSfV6yBrapU89p5fKekE2m/NwnDocOVruQFS1/veMgdzuPcnOM34M6CwxW8jH/lxEa5rBoDeUwu5HHTw== -semver@^7.3.2, semver@^7.3.4: +semver@^7.3.2, semver@^7.3.4, semver@^7.3.5: version "7.3.5" resolved "https://registry.yarnpkg.com/semver/-/semver-7.3.5.tgz#0b621c879348d8998e4b0e4be94b3f12e6018ef7" integrity sha512-PoeGJYh8HK4BTO/a9Tf6ZG3veo/A7ZVsYrSA6J8ny9nb3B1VrpkuN+z9OE5wfE5p6H4LchYZsegiQgbJD94ZFQ==