-
Notifications
You must be signed in to change notification settings - Fork 2.2k
speed up test build time breaks Codeship CI #572
Comments
Having never used Codeship, is there anything different about its environment than yours? I just signed up for Codeship and will try to reproduce, but it seems incredibly strange that this only occurs in that environment. On a related note, I also merged those same fixes into our applications at work (CircleCI) and we haven't run into any issues. Will try to repro on Codeship and see how it goes. |
No, never had the feeling that the codeship environment is different from ours. Thanks for investigating this issue. |
Well, reproducing at least: https://codeship.com/projects/134857/builds/12222450 |
I have the same error on CodeShip. I think that is because the phantomjs version on codeship servers is "1.9.7", and on local I use "2.1.1". |
I'm having the exact same problem when running tests on Codeship. Mine although is running on Phantom 2.1.1.
from |
Could this be related to eslint/eslint#2228? |
Same Issue running tests inside a local Docker image |
I don't know what the cause of this was, but I resolved it by changing this line from: const __karmaWebpackManifest__ = [] // eslint-disable-line to: const __karmaWebpackManifest__ = new Array() // eslint-disable-line Alternatively a semicolon at the end of the line seems to resolve the problem. |
@gerbal that's so strange to me. Especially that it would only cause issues in very particular environments. |
Thank you @gerbal for your research. |
Hey Devs,
after we merged the latest improvements regarding the test build time (commit 998cce6), we recognized that our builds on Codeship CI are failing due to an
SyntaxError: Expected token ']'
error.On our local machines (MacOSX and Ubuntu with PhantomJS 2.1.1) it works fine to run the tests though.
I can also easily reproduce this error, when I fork the original react-redux-starter-kit master and connect it with codeship. It breaks with this error and I assume it belongs to the karma-webpack-with-fast-source-maps package.
Screenshot is attached:
Any hints?
The text was updated successfully, but these errors were encountered: