From 89d77113b028bbebe443ee24b2bdbc4c9dd1e357 Mon Sep 17 00:00:00 2001 From: Philippe Rolet Date: Mon, 6 May 2024 09:33:35 +0200 Subject: [PATCH] Confluence error handling: catch fetch aborts (#4979) Description --- Those errors occur on the confluence connector when fetch is aborted. Apparently a timeout can cause either an "AbortError" or a "TimeoutError" https://github.com/nodejs/node/issues/43874 --- .../src/connectors/confluence/lib/confluence_client.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/connectors/src/connectors/confluence/lib/confluence_client.ts b/connectors/src/connectors/confluence/lib/confluence_client.ts index c5a39d85f852..d7d5bdeb825e 100644 --- a/connectors/src/connectors/confluence/lib/confluence_client.ts +++ b/connectors/src/connectors/confluence/lib/confluence_client.ts @@ -164,7 +164,10 @@ export class ConfluenceClient { signal: AbortSignal.timeout(30000), }); } catch (e) { - if (e instanceof DOMException && e.name === "TimeoutError") { + if ( + e instanceof DOMException && + (e.name === "TimeoutError" || e.name === "AbortError") + ) { throw new ConfluenceClientError("Request timed out", { type: "http_response_error", status: 504,