Add the compact module to add non-rust compatiblity #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the same exact rng provide when generating output notes
Add support for mnemonic
Fix clippy warnings
Use old note picking technique Pass openings with corresponding note positions
Add has_key to stakeinfo response
Send tx hash with prove Tx
Add support for calculating tx history
ZER0
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
We fixed the error on decompose, the wallet-core would need a bigger refactoring that is not manageable at the moment given our timeline. So let's land this PR as is, and focus on the wallet-js library for the time being; we'll go back to wallet-core once we have the time capacity to do so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the only module that contains utility functions which are all you need to work with our dusk crypto primitives and serialization from any non-rust/rust platform