Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure integration tests #731

Closed
moCello opened this issue Jan 30, 2023 · 0 comments · Fixed by #732
Closed

Restructure integration tests #731

moCello opened this issue Jan 30, 2023 · 0 comments · Fixed by #732
Labels
team:Core Low Level Core Development Team (Rust) team:research

Comments

@moCello
Copy link
Member

moCello commented Jan 30, 2023

Describe what you want implemented
Restructure integration tests and add common setup and verification functions that all tests can use.

Describe "Why" this is needed
Reduce test boilerplate. This way it becomes more transparent what is actually tested and easier to add new tests.

Describe alternatives you've considered
The tests essentially are unit tests (testing one specific functionality/function) but because the testing happens in-circuit and benefit from helper functions, I have kept them as integrations tests.

Additional context
The workload is split over multiple issues. This issue covers:

  • add helper functions:
    • setup
    • check_satisfied_circuit
    • check_unsatisfied_circuit
  • refactor tests:
    • assert_equal_point
    • assert_equal_public_point
    • component_mul_point
    • component_add_point
    • component_mul_generator
    • component_boolean
    • component_select
    • component_select_one
    • component_select_zero
    • component_select_point
    • component_select_identity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:Core Low Level Core Development Team (Rust) team:research
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant