unable to require jade (throws: EINVAL)

[stephenmathieson]

i've simplified my issue down to:

require('visionmedia/jade')

attempting to build results in an EINVAL:

$ DEBUG=duo*,gh-resolve duo index.js
Thu, 07 Aug 2014 15:37:46 GMT duo-package read auth details from ~/.netrc
Thu, 07 Aug 2014 15:37:46 GMT duo using plugin: stoj
Thu, 07 Aug 2014 15:37:46 GMT duo parsing: index.js
Thu, 07 Aug 2014 15:37:46 GMT duo index.js deps: ["visionmedia/jade"]
Thu, 07 Aug 2014 15:37:46 GMT duo-package visionmedia-jade@*: resolving
Thu, 07 Aug 2014 15:37:46 GMT gh-resolve executing: git ls-remote --tags --heads https://[email protected]/visionmedia/jade
Thu, 07 Aug 2014 15:37:47 GMT gh-resolve executed: git ls-remote --tags --heads https://[email protected]/visionmedia/jade
Thu, 07 Aug 2014 15:37:47 GMT duo-package [email protected]: resolved
Thu, 07 Aug 2014 15:37:47 GMT duo-package [email protected]: extracting from cache

        error : Error: [email protected]: EINVAL, symlink ''
    at Package.error (/Users/stephenmathieson/repos/duo/duo/node_modules/duo-package/lib/index.js:604:10)
    at error (/Users/stephenmathieson/repos/duo/duo/node_modules/duo-package/lib/index.js:547:22)
    at emit (events.js:117:20)
    at Extract.destroy (/Users/stephenmathieson/repos/duo/duo/node_modules/duo-package/node_modules/tar-fs/node_modules/tar-stream/extract.js:140:16)
    at onunlock (/Users/stephenmathieson/repos/duo/duo/node_modules/duo-package/node_modules/tar-fs/node_modules/tar-stream/extract.js:53:24)
    at stat (/Users/stephenmathieson/repos/duo/duo/node_modules/duo-package/node_modules/tar-fs/index.js:196:20)
    at Object.oncomplete (fs.js:107:15)

stephenmathieson at MBP in ~/tmp

i know i probably should be using duo-jade, but the cli doesn't offer plugins yet :/

btw: using duo@master (80665de) on node 0.11.13

[dominicbarnes]

You know, I created a branch with support for basic plugins late last night... would you like to give it a spin? I didn't test it myself yet, since I didn't have a ported application quite yet, but since you are needing it now we can probably expedite this process :)

[dominicbarnes]

Check out the plugins branch of component/duo. It's simple, but I think it will work.

[stephenmathieson]

nice! yeah, a plugin would be best here. i'll give your branch a try ;)

i still think this is an issue though. whatever is causing this is likely going to be problematic for other repos too, right?

[matthewmueller]

can i close this? you can use the CLI now or use duo-jade

[stephenmathieson]

hmm well the cli fixes this issue for now, but it looks like Package#extract dies on symlinks. i'm sure this will come up again, as there are other repositories that contain symlinks..

[matthewmueller]

i'm not sure i understand, your extracting from a symlink?

[stephenmathieson]

the jade repo contains a symlink, so yes, i'm extracting one. package#extract() throws because of this.

edit: https://github.com/visionmedia/jade/blob/master/lib/index.js

[matthewmueller]

okay, so just that require is failing because of a symlink. is the symlink within the repo visionmedia/jade? i guess i've never heard of committing a symlink before..

[stephenmathieson]

yeah, there's a symlink in the repo (see the link above). idk why it's there. pretty dumb imo, but w/e.

im not sure how big of a problem this is, but if other users have symlinks in their repos, this could cause issues in the future.

[matthewmueller]

alrighty, closing in favor of: duojs/package#38

[stephenmathieson]

makes sense