Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 192 #234

Merged
merged 3 commits into from
Mar 16, 2018
Merged

Fix 192 #234

merged 3 commits into from
Mar 16, 2018

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Mar 7, 2018

This would solve #192.
My mentor @AnthonyLloyd and I came up with this as part of the F# Mentorship program.

There is currently no setting to indicate whether you want a single DU to be on one line or not.
And if the type has any members it will use a newline anyway.
Let us know if this requires further improvements.

We would be willing to resolve other issues as well. And perhaps try and migrate the project to a dotnet cli tool one day.

Copy link
Contributor

@jindraivanek jindraivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

Copy link
Contributor

@dungpa dungpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for contributing.

@dungpa dungpa merged commit 7b133fa into fsprojects:master Mar 16, 2018
@nojaf nojaf deleted the fix-192 branch March 16, 2018 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants